Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): Importing a JobDefinition from name using fromJobDefinitionName #10448

Merged
merged 3 commits into from
Sep 30, 2020
Merged

feat(batch): Importing a JobDefinition from name using fromJobDefinitionName #10448

merged 3 commits into from
Sep 30, 2020

Conversation

ayush987goyal
Copy link
Contributor

Add fromJobDefinitionName for JobDefinition construct. Ref: https://stackoverflow.com/a/55031183

closes #7172


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 30, 2020
@iliapolo iliapolo removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Sep 30, 2020
@iliapolo iliapolo changed the title feat(batch): add "fromJobDefinitionName" import helper feat(batch): Importing a JobDefinition from name using fromJobDefinitionName Sep 30, 2020
iliapolo
iliapolo previously approved these changes Sep 30, 2020
@mergify mergify bot dismissed iliapolo’s stale review September 30, 2020 11:44

Pull request has been modified.

@ayush987goyal
Copy link
Contributor Author

@iliapolo Could you please approve it again? The auto-build failed because of some intermittent issue due to which I manually merged from master.

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 405b742
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 7ce91e8 into aws:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-batch JobDefinition: Support import using 'fromJobDefinitionName'
3 participants