fix(rds): standardize removal policies and deletion protection #10412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, database instances and clusters have different behaviors for removal policies and deletion protection. This fix standardizes the behavior and logical code paths so RDS behaves consistently. The new logic is that we will only set `deletionProtection` if the RemovalPolicy has been set to RETAIN. Otherwise (with SNAPSHOT or DELETE), deletion protection will be disabled (by default).
skinny85
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Looks great, but we absolutely need to mark this with BREAKING CHANGES, and with the multiple breaking changes format in fact.
Maybe something like this?
BREAKING CHANGE: Cluster now has default deletionProtection enabled if its removal policy is `RETAIN`
* **rds**: Instance now has deletionProtection enabled by default only if its removal policy is `RETAIN`
Co-authored-by: Adam Ruka <[email protected]>
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, database instances and clusters have different behaviors for
removal policies and deletion protection. This fix standardizes the behavior
and logical code paths so RDS behaves consistently.
The new logic is that we will only set
deletionProtectionif the RemovalPolicyhas been set to RETAIN. Otherwise (with SNAPSHOT or DELETE), deletion protection
will be disabled (by default).
BREAKING CHANGE: Cluster now has deletionProtection enabled if its removal policy is
RETAINRETAINBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license