Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rds): add SQL Server version 15.00.4043.16.v1 #10289

Merged
merged 9 commits into from
Sep 16, 2020
Merged

feat(rds): add SQL Server version 15.00.4043.16.v1 #10289

merged 9 commits into from
Sep 16, 2020

Conversation

abjoshi2785
Copy link
Contributor

@abjoshi2785 abjoshi2785 commented Sep 10, 2020 •
edited by skinny85
Loading

Closes #10273

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@abjoshi2785
fix(rds)- support for sql version 15.00.4043.16.v1
79bc436 
Fix for [rds] Support for RDS SQL Version 15.00.4043.16.v1 aws#10273
@abjoshi2785 abjoshi2785 changed the title Fix for [rds] Support for RDS SQL Version 15.00.4043.16.v1 #10273 Fix[rds] Support for RDS SQL Version 15.00.4043.16.v1 #10273 Sep 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@abjoshi2785 abjoshi2785 changed the title Fix[rds] Support for RDS SQL Version 15.00.4043.16.v1 #10273 fix[rds]: support for sql version 15.00.4043.16.v1 #10273 Sep 10, 2020
@skinny85 skinny85 changed the title fix[rds]: support for sql version 15.00.4043.16.v1 #10273 fix(rds): add SQL Server version 15.00.4043.16.v1 Sep 10, 2020
shivlaks
shivlaks previously approved these changes Sep 10, 2020
View reviewed changes
@shivlaks shivlaks added the pr/do-not-merge This PR should not be merged at this time. label Sep 10, 2020
@mergify mergify bot dismissed shivlaks’s stale review September 10, 2020 16:33

Pull request has been modified.

@shivlaks shivlaks changed the title fix(rds): add SQL Server version 15.00.4043.16.v1 chore(rds): add SQL Server version 15.00.4043.16.v1 Sep 10, 2020
skinny85
skinny85 previously requested changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @abjoshi2785 !

packages/@aws-cdk/aws-rds/lib/instance-engine.ts Show resolved Hide resolved
@njlynch njlynch dismissed skinny85’s stale review September 10, 2020 17:31

Added the newline.

skinny85
skinny85 previously approved these changes Sep 10, 2020
View reviewed changes
@shivlaks shivlaks removed the pr/do-not-merge This PR should not be merged at this time. label Sep 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed skinny85’s stale review September 11, 2020 12:58

Pull request has been modified.

njlynch
njlynch previously approved these changes Sep 15, 2020
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85
Copy link
Contributor

@abjoshi2785 did you "Allow changes to be pushed to your fork"? I think we can't merge your PR until you do...

skinny85
skinny85 previously requested changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting in "Request changes" to try and unblock the Mergify queue.

@mergify mergify bot dismissed skinny85’s stale review September 16, 2020 02:43

Pull request has been modified.

@mergify mergify bot dismissed njlynch’s stale review September 16, 2020 02:43

Pull request has been modified.

skinny85
skinny85 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the queue is unclogged, approving again 🙂

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 changed the title chore(rds): add SQL Server version 15.00.4043.16.v1 feat(rds): add SQL Server version 15.00.4043.16.v1 Sep 16, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7c12e46
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a578ef8 into aws:master Sep 16, 2020
@abjoshi2785
Copy link
Contributor Author

Thank you! :)

@skinny85
Copy link
Contributor

Thank you! :)

No, thank you for the contribution 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivlaks shivlaks shivlaks left review comments

@skinny85 skinny85 skinny85 approved these changes

@njlynch njlynch njlynch left review comments

Assignees

@skinny85 skinny85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rds] Support for RDS SQL Version 15.00.4043.16.v1
5 participants
@abjoshi2785 @skinny85 @aws-cdk-automation @njlynch @shivlaks