Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support credential_source in aws shared config file #10272

Merged
merged 51 commits into from
Sep 10, 2020

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Sep 9, 2020

Added support for using credential_source in the standard aws config file.

This wasn't previously supported because the JavaScript SDK does not support it.

This PR bypasses the limitation.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 9, 2020
@iliapolo iliapolo requested a review from rix0rrr September 9, 2020 16:26
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Couple of small tweaks

@iliapolo iliapolo added the pr-linter/exempt-readme The PR linter will not require README changes label Sep 10, 2020
@iliapolo iliapolo marked this pull request as ready for review September 10, 2020 09:18
@iliapolo iliapolo requested a review from rix0rrr September 10, 2020 09:19
@rix0rrr rix0rrr added the pr/do-not-merge This PR should not be merged at this time. label Sep 10, 2020
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally okay modulo some wording changes we discussed

@iliapolo iliapolo removed the pr/do-not-merge This PR should not be merged at this time. label Sep 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 940a443 into master Sep 10, 2020
@mergify mergify bot deleted the epolon/cli-support-credential-source-auth branch September 10, 2020 10:28
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 74b7183
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants