-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): deprecate OracleSE and OracleSE1 engine versions #10241
Conversation
Oracle 11.x and the SE and SE1 engines are no longer supported by Oracle (and RDS). As of Sep 1, 2020, no new instances can be launched with these engines (with the license-included license type). Support for bring-your-own-license instances will be removed Oct 1. See https://forums.aws.amazon.com/ann.jspa?annID=7341 for more details. fixes #9249
@@ -507,6 +507,8 @@ class PostgresInstanceEngine extends InstanceEngineBase { | |||
* (those returned by {@link DatabaseInstanceEngine.oracleSe} | |||
* and {@link DatabaseInstanceEngine.oracleSe1}). | |||
* Note: RDS will stop allowing creating new databases with this version in August 2020. | |||
* | |||
* @deprecated instances can no longer be created with these engine versions. See https://forums.aws.amazon.com/ann.jspa?annID=7341 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeeeaaahhhh... we have a tough decision to make here.
I think in the discussion room we said that we shouldn't mark these as @deprecated
, because that means they will get removed in v2 and that means existing applications (with databases that were deployed previously and continue to run fine) will be broken with no way to recover.
So I guess just a note by itself will have to do.
I'm also fine to invent a new annotation like @unsupported
or something. It will render as regular text everywhere, until we add support for it to the docs to add a symbol or a color or something to distinguish it from the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, simply add 'DEPRECATED' or 'NOT RECOMMENDED FOR USE' in all caps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change the conversation at all?
Starting on November 1, 2020, Amazon RDS Oracle will automatically upgrade DB instances from 11.2.0.4 on SE1 LI to the latest Release Update (RU) on RDS for Oracle Database 19c SE2 LI during the scheduled maintenance window.
I don't think any reasonable plan is for v2 to be released before Nov 1. For existing applications past that point, keeping the SE1 references would actually mean a cdk diff
would show a downgrade, and attempting to deploy that downgrade would fail, so existing applications are going to need to update regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok going with @deprecated
if you would like this to be removed for CDKv2. Totally!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change the conversation at all?
Starting on November 1, 2020, Amazon RDS Oracle will automatically upgrade DB instances from 11.2.0.4 on SE1 LI to the latest Release Update (RU) on RDS for Oracle Database 19c SE2 LI during the scheduled maintenance window.
I don't think any reasonable plan is for v2 to be released before Nov 1. For existing applications past that point, keeping the SE1 references would actually mean a
cdk diff
would show a downgrade, and attempting to deploy that downgrade would fail, so existing applications are going to need to update regardless.
That does change things, yes. Since RDS will be changing these in the backend themselves, I'm fine with removing these in v2.0, and thus marking them as deprecated here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -507,6 +507,8 @@ class PostgresInstanceEngine extends InstanceEngineBase { | |||
* (those returned by {@link DatabaseInstanceEngine.oracleSe} | |||
* and {@link DatabaseInstanceEngine.oracleSe1}). | |||
* Note: RDS will stop allowing creating new databases with this version in August 2020. | |||
* | |||
* @deprecated instances can no longer be created with these engine versions. See https://forums.aws.amazon.com/ann.jspa?annID=7341 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change the conversation at all?
Starting on November 1, 2020, Amazon RDS Oracle will automatically upgrade DB instances from 11.2.0.4 on SE1 LI to the latest Release Update (RU) on RDS for Oracle Database 19c SE2 LI during the scheduled maintenance window.
I don't think any reasonable plan is for v2 to be released before Nov 1. For existing applications past that point, keeping the SE1 references would actually mean a
cdk diff
would show a downgrade, and attempting to deploy that downgrade would fail, so existing applications are going to need to update regardless.
That does change things, yes. Since RDS will be changing these in the backend themselves, I'm fine with removing these in v2.0, and thus marking them as deprecated here.
We do want to remove this in v2. Discussed offline.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Oracle 11.x and the SE and SE1 engines are no longer supported by Oracle
(and RDS). As of Sep 1, 2020, no new instances can be launched with these
engines (with the license-included license type). Support for
bring-your-own-license instances will be removed Oct 1.
Also took the opportunity to remove deprecated usages of version-less engines
from the README.
See https://forums.aws.amazon.com/ann.jspa?annID=7341 for more details.
fixes #9249
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license