feat(secrets-manager): exclude characters for password rotation applications #10110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahammond
force-pushed
the
support-excluded-characters-in-password-rotation
branch
from
3f393a6 to
8fd3287
Compare
SomayaB
changed the title
corrjo
approved these changes
Sep 2, 2020
njlynch
changed the title
njlynch
previously requested changes
Sep 3, 2020
mergify
bot
dismissed
njlynch’s stale review
Pull request has been modified.
Co-authored-by: Nick Lynch <[email protected]>
|
@njlynch I've added the UTs and made the wording change you suggested. Thank you! |
mergify
bot
dismissed
njlynch’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
ahammond
deleted the
support-excluded-characters-in-password-rotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EXCLUDED_CHARACTERS part of #4144