From 3e1295c1a2f84949fd38617a20edec2e15d3c46f Mon Sep 17 00:00:00 2001 From: Piradeep Kandasamy Date: Fri, 3 May 2019 10:45:09 -0700 Subject: [PATCH] Address feedback --- packages/@aws-cdk/aws-ecs/test/test.l3s.ts | 26 +++------------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/packages/@aws-cdk/aws-ecs/test/test.l3s.ts b/packages/@aws-cdk/aws-ecs/test/test.l3s.ts index 40b14ef042ea7..e36a5a2005f9f 100644 --- a/packages/@aws-cdk/aws-ecs/test/test.l3s.ts +++ b/packages/@aws-cdk/aws-ecs/test/test.l3s.ts @@ -26,7 +26,7 @@ export = { } }); - // THEN - stack containers a load balancer and a service + // THEN - stack contains a load balancer and a service expect(stack).to(haveResource('AWS::ElasticLoadBalancingV2::LoadBalancer')); expect(stack).to(haveResource("AWS::ECS::Service", { @@ -66,35 +66,15 @@ export = { new ecs.LoadBalancedEc2Service(stack, 'Service', { cluster, memoryReservationMiB: 1024, - image: ecs.ContainerImage.fromRegistry('test'), - desiredCount: 2, - environment: { - TEST_ENVIRONMENT_VARIABLE1: "test environment variable 1 value", - TEST_ENVIRONMENT_VARIABLE2: "test environment variable 2 value" - } + image: ecs.ContainerImage.fromRegistry('test') }); - // THEN - stack containers a load balancer and a service + // THEN - stack contains a load balancer and a service expect(stack).to(haveResource('AWS::ElasticLoadBalancingV2::LoadBalancer')); - expect(stack).to(haveResource("AWS::ECS::Service", { - DesiredCount: 2, - LaunchType: "EC2", - })); - expect(stack).to(haveResourceLike('AWS::ECS::TaskDefinition', { ContainerDefinitions: [ { - Environment: [ - { - Name: "TEST_ENVIRONMENT_VARIABLE1", - Value: "test environment variable 1 value" - }, - { - Name: "TEST_ENVIRONMENT_VARIABLE2", - Value: "test environment variable 2 value" - } - ], MemoryReservation: 1024 } ]