From 22ed67c7c868b48ce72c203b1e8dccc8c64d97f3 Mon Sep 17 00:00:00 2001 From: Rico Huijbers Date: Wed, 10 Apr 2019 11:58:14 +0200 Subject: [PATCH] fix(toolkit): remove metadata warning if region does not have resource (#2216) --- packages/aws-cdk/lib/api/cxapp/stacks.ts | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/packages/aws-cdk/lib/api/cxapp/stacks.ts b/packages/aws-cdk/lib/api/cxapp/stacks.ts index 85cea47b6a9ab..7d913155e2a70 100644 --- a/packages/aws-cdk/lib/api/cxapp/stacks.ts +++ b/packages/aws-cdk/lib/api/cxapp/stacks.ts @@ -193,15 +193,17 @@ export class AppStacks { } const resourcePresent = stack.environment.region === 'default-region' || regionInfo.Fact.find(stack.environment.region, regionInfo.FactName.cdkMetadataResourceAvailable) === 'YES'; - if (!stack.template.Resources.CDKMetadata && resourcePresent) { - stack.template.Resources.CDKMetadata = { - Type: 'AWS::CDK::Metadata', - Properties: { - Modules: modules - } - }; - } else { - warning(`The stack ${stack.name} already includes a CDKMetadata resource`); + if (resourcePresent) { + if (!stack.template.Resources.CDKMetadata) { + stack.template.Resources.CDKMetadata = { + Type: 'AWS::CDK::Metadata', + Properties: { + Modules: modules + } + }; + } else { + warning(`The stack ${stack.name} already includes a CDKMetadata resource`); + } } } }