From 0171ac9ca143b8d82fc17d7c2ddc6f88a5e0f40b Mon Sep 17 00:00:00 2001 From: Markus Wolf Date: Tue, 18 Jun 2019 17:53:54 +0200 Subject: [PATCH] refactor: update based on review --- packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts | 2 +- packages/@aws-cdk/aws-lambda/lib/lambda-version.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts b/packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts index c498b44400d89..3823553af8704 100644 --- a/packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts +++ b/packages/@aws-cdk/aws-cloudfront/lib/web_distribution.ts @@ -363,7 +363,7 @@ export interface LambdaFunctionAssociation { readonly eventType: LambdaEdgeEventType; /** - * A version of the lambda to associate or a resolvable resource + * A version of the lambda to associate */ readonly lambdaFunction: lambda.IVersion; } diff --git a/packages/@aws-cdk/aws-lambda/lib/lambda-version.ts b/packages/@aws-cdk/aws-lambda/lib/lambda-version.ts index 9cdd3d4746b45..44950cf6c6c3f 100644 --- a/packages/@aws-cdk/aws-lambda/lib/lambda-version.ts +++ b/packages/@aws-cdk/aws-lambda/lib/lambda-version.ts @@ -74,6 +74,8 @@ export interface VersionAttributes { export class Version extends QualifiedFunctionBase implements IVersion { /** + * Construct a Version object from a Version ARN. + * * @param scope The cdk scope creating this resource * @param id The cdk id of this resource * @param versionArn The version ARN to create this version from @@ -155,8 +157,6 @@ export class Version extends QualifiedFunctionBase implements IVersion { * * ..which means that in order to extract the `function arn` component from the ARN, we can * split the ARN using ":" and join indices 0-6. - * - * @returns `FnSelect(7, FnSplit(':', arn))` */ function extractFunctionArnFromVersionArn(arn: string) { return Fn.join(':', [