Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: 0164 Construct library segments #169

Closed
wants to merge 1 commit into from
Closed

RFC: 0164 Construct library segments #169

wants to merge 1 commit into from

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Jun 4, 2020

Rendered version

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache-2.0 license

@nija-at nija-at self-assigned this Jun 4, 2020
@nija-at nija-at requested a review from a team June 4, 2020 11:02
@mergify
Copy link
Contributor

mergify bot commented Jun 4, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@nija-at nija-at force-pushed the nija-at/segments branch 2 times, most recently from 27bc6e3 to eb6394e Compare June 4, 2020 11:07
@nija-at nija-at force-pushed the nija-at/segments branch from eb6394e to 8df58f1 Compare June 4, 2020 11:09
@nija-at nija-at added the contribution/core This is a PR that came from AWS label Jun 4, 2020
eladb
eladb reviewed Jun 7, 2020
View reviewed changes
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed something but I am failing to understand what are the implications from a user’s standpoint besides roadmap granularity and the table in documentation. Are there any implications when importing/defining resources?

@nija-at
Copy link
Contributor Author

nija-at commented Jun 8, 2020

I might have missed something but I am failing to understand what are the implications from a user’s standpoint besides roadmap granularity and the table in documentation. Are there any implications when importing/defining resources?

There are no other implications besides better customer communication.

@eladb
Copy link
Contributor

eladb commented Jun 8, 2020

I might have missed something but I am failing to understand what are the implications from a user’s standpoint besides roadmap granularity and the table in documentation. Are there any implications when importing/defining resources?

There are no other implications besides better customer communication.

So basically the proposal is to add a stability label for each module’s README with a list of segments, and also manage the roadmap at the segment level.

Maybe worth adding to the beginning of the RFC

@nija-at nija-at mentioned this pull request Jun 19, 2020
Closed
7 tasks
@nija-at nija-at closed this Jun 19, 2020
@eladb eladb changed the title RFC: 0164 construct library segments RFC: 0164 Construct library segments Jun 22, 2020
@nija-at nija-at deleted the nija-at/segments branch August 24, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb left review comments

Assignees

@nija-at nija-at

Labels
contribution/core This is a PR that came from AWS management/rfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nija-at @eladb