Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Route's status blindly change to ResolvedRefs==True even if the controller was NOT able to resolve all the object references for the Route #544

Closed
zijun726911 opened this issue Nov 24, 2023 · 1 comment · Fixed by #563
Assignees
Labels
groomed reviewed during grooming session

Comments

@zijun726911
Copy link
Contributor

zijun726911 commented Nov 24, 2023

The Route's status blindly change to ResolvedRefs==True even if the controller was NOT able to resolve all the object references for the Route

How to reproduce it: for the controller version v1.0.1

  1. kubectl apply -f examples/my-hotel-gateway.yaml
  2. Change the content of examples/inventory-route.yaml:
        apiVersion: gateway.networking.k8s.io/v1beta1
        kind: HTTPRoute
        metadata:
          name: inventory
        spec:
          parentRefs:
          - name: my-hotel
            sectionName: http
          rules:
          - backendRefs:
            - name: my-no-existing-service
              kind: Service
              port: 80
              weight: 10
  1. do kubectl apply -f examples/inventory-route.yaml
  2. Wait until the controller reconciled, I could see in the vpc lattice console that the lattice service inventory-default and serviceAssociation created successfully
  3. do kubectl get httproute inventory -o yaml I could see:
status:
  parents:
  - conditions:
    - lastTransitionTime: "2023-11-24T21:14:23Z"
      message: 'DNS Name: inventory-default-09b2aa51cffc3ccf5.7d67968.vpc-lattice-svcs.us-west-2.on.aws'
      observedGeneration: 1
      reason: Accepted
      status: "True"
      type: Accepted
    - lastTransitionTime: "2023-11-24T21:14:23Z"
      message: 'DNS Name: inventory-default-09b2aa51cffc3ccf5.7d67968.vpc-lattice-svcs.us-west-2.on.aws'
      observedGeneration: 1
      reason: ResolvedRefs
      status: "True"
      type: ResolvedRefs
    controllerName: application-networking.k8s.aws/gateway-api-controller

ResolvedRefs == True is not correct since my cluster don't have my-no-existing-service k8s Service. Also seem it miss the Programmed status

@zijun726911 zijun726911 changed the title The Route's status blindly change to ResolvedRefs==True even if it the controller was able to resolve all the object references for the Route The Route's status blindly change to ResolvedRefs==True even if the controller was NOT able to resolve all the object references for the Route Nov 24, 2023
@mikhail-aws mikhail-aws self-assigned this Nov 28, 2023
@mikhail-aws mikhail-aws added the groomed reviewed during grooming session label Nov 28, 2023
@mikhail-aws mikhail-aws added this to the Release v1.0.2 milestone Nov 28, 2023
@mikhail-aws
Copy link
Contributor

Route does not have Programmed status type. Only "Accepted", "PartiallyInvalid", "ResolvedRefs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groomed reviewed during grooming session
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants