Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in logs when Service Network already have a VPC association, print memory addr instead of SNVA ARN #540

Closed
allamand opened this issue Nov 22, 2023 · 0 comments · Fixed by #563
Assignees
Labels
groomed reviewed during grooming session

Comments

@allamand
Copy link
Contributor

The logs shows the internal address of the VPC instead of the real value

aws-gateway-api-controller-aws-gateway-controller-chart-7bsfsd9 manager {"level":"debug","ts":"2023-11-22T13:05:42.660Z","logger":"controller.gateway","caller":"lattice/service_network_manager.go:195","msg":"ServiceNetwork app-services-gw already has VPC association %!s(*string=0xc0005fe0f0)"}

Seems the vpc are is a pointer, here we print it's address which is not useful

m.log.Debugf("ServiceNetwork %s already has VPC association %s", serviceNetwork.Spec.Name, snva.Arn)

@mikhail-aws mikhail-aws self-assigned this Nov 22, 2023
@graehren graehren added the groomed reviewed during grooming session label Nov 22, 2023
@mikhail-aws mikhail-aws changed the title Error in logs when Service Network already have a VPC association, print memory instead of vic) Error in logs when Service Network already have a VPC association, print memory addr instead of SNVA ARN Nov 24, 2023
@mikhail-aws mikhail-aws added this to the Release v1.0.2 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groomed reviewed during grooming session
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants