Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid BackendRef should not block route creation/update #493

Closed
erikfuller opened this issue Nov 10, 2023 · 1 comment
Closed

Invalid BackendRef should not block route creation/update #493

erikfuller opened this issue Nov 10, 2023 · 1 comment

Comments

@erikfuller
Copy link
Contributor

According to the spec, invalid backendRefs should return a 500 rather than block route creation or updates. Lattice does not currently support fixed responses outside of 404, so we will return that for now.

Current behaviour (as originally highlighted by @zijun726911 offline) and steps to reproduce:

kubectl apply -f examples/my-hotel-gateway.yaml
kubectl apply -f examples/inventory-route.yaml

By creating a route with no backing service, we will see errors like:

failed at BuildModel: {“logger”:“controller.route”,“caller”:“controllers/route_controller.go:282”,“msg”:“buildAndDeployModel, Failed build model for salmo-5-ok4zh8ytnj due to failed to build rules due to buildTargetGroupSpec err error finding backend service e2e-test/bugmu-2-tfbytur05o due to Service \“bugmu-2-tfbytur05o\” not found”}

This will never succeed until the service is created.

@erikfuller
Copy link
Contributor Author

Fix for this in the attached PR. Follow up is #494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant