Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetGroupPolicy and VpcAssociationPolicy CRD status Update #440

Closed
zijun726911 opened this issue Oct 17, 2023 · 1 comment · Fixed by #509
Closed

TargetGroupPolicy and VpcAssociationPolicy CRD status Update #440

zijun726911 opened this issue Oct 17, 2023 · 1 comment · Fixed by #509
Assignees
Labels
groomed reviewed during grooming session

Comments

@zijun726911
Copy link
Contributor

Currently controller behavior is: if multiple TargetGroupPolicies (tgp), VpcAssociationPolicies(vap) apply to the same k8s obj, only the first policy will take effect and the controller will ignore the rest of policies(will print a error log for it). If that happen, we should use a better way to represent this error by updating policy status: for example, If there are two tgps attached to one svc(serviceExport), one policy is set to accepted status and the other one is set to conflicted status.

(Other policies CRDs or even other controller managed k8s objs may also need proper status update )

@graehren
Copy link
Collaborator

Thanks for reporting the issue, we will be investigating it further. Please watch this channel for more updates, and feel free to reach out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groomed reviewed during grooming session
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants