Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Windows warm/minimum IP targets #370

Open
jdn5126 opened this issue Feb 19, 2024 · 1 comment · Fixed by #371
Open

Rename Windows warm/minimum IP targets #370

jdn5126 opened this issue Feb 19, 2024 · 1 comment · Fixed by #371
Assignees
Labels
enhancement New feature or request

Comments

@jdn5126
Copy link
Contributor

jdn5126 commented Feb 19, 2024

What would you like to be enhanced:
I would like to rename the Windows warm/minimum IP target variables that are read from the amazon-vpc-cni ConfigMap: https://github.com/aws/amazon-vpc-resource-controller-k8s/blob/master/pkg/config/type.go#L76

The current names cause confusion with the environment variables in the aws-node Daemonset that are used for warm/minimum targets on Linux nodes. I propose that we rename these to windows-*.

Since we cannot do the switchover all at once, I propose the VPC Resource Controller starts accepting both names, which will allow the AWS VPC CNI chart to change its names to the windows-* values.

Why is the change needed and what use case will it solve:
This change would help avoid customer confusion when it comes to deploying the AWS VPC CNI chart.

@jdn5126 jdn5126 added the enhancement New feature or request label Feb 19, 2024
@haouc
Copy link
Contributor

haouc commented Feb 19, 2024

Thanks @jdn5126 , it makes sense to rename them to be aligned with Windows use case and avoid confusion with Linux use cases.

@haouc haouc self-assigned this Feb 19, 2024
@sushrk sushrk linked a pull request Feb 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants