Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer controller-gen doesn't correctly recognize markers. Need upgrade. #199

Open
haouc opened this issue Apr 4, 2023 · 1 comment · Fixed by #369
Open

Newer controller-gen doesn't correctly recognize markers. Need upgrade. #199

haouc opened this issue Apr 4, 2023 · 1 comment · Fixed by #369
Labels
enhancement New feature or request

Comments

@haouc
Copy link
Contributor

haouc commented Apr 4, 2023

What would you like to be enhanced:
Looks like the controller is still using 0.6.x controller-tools to manage markers. Controller-gen has a breaking change from 0.7 and the latest version is 0.11.x. This project need to upgrade markers to use newer controller-tools.
Why is the change needed and what use case will it solve:
This project is still using an old controller-tool version. It should be upgraded to work with newer controller-tools version.

@haouc haouc added the enhancement New feature or request label Apr 4, 2023
@sushrk sushrk linked a pull request Feb 6, 2024 that will close this issue
@sushrk
Copy link
Contributor

sushrk commented Feb 6, 2024

Partly addressed in #369

go/v4 is the default version now, https://book.kubebuilder.io/plugins/go-v4-plugin

Keeping this issue open till be move to v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants