-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(compose): Add EFS volume support to ECS Params. #1019
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
1bc10f7
Update sdk dependency
bvtujo ccade5e
add EFS volume struct to converter
bvtujo d9858e4
hardcode fargate platform 1.4.0 for efs
bvtujo 1e7cd18
Add working unit test
bvtujo ec3ca84
Update mocks and clients
bvtujo 5b6c58b
Add platform version todo
bvtujo e2f1b99
Update ecs-cli/modules/cli/compose/entity/service/service.go
bvtujo 5c10c9f
Add warnings and logic for switching PV to 1.4.0 for EFS tasks
bvtujo e5bf26d
Remove unnecessary asserts and print in convert task def test
bvtujo b1c707d
Add error if EFS volume name is not specified
bvtujo 932633b
Rename temp var from dvol to vol to reduce confusion
bvtujo 04f1f7c
Update ecs-params in readme
bvtujo 67ea655
add section describing EFS to readme
bvtujo ce63155
Add example ECS params with EFS
bvtujo 80ecf60
Edit warning to imply that we will use PV 1.4.0 if necessary
bvtujo 702c0cd
fix error message in efs volume
bvtujo d26c48b
Add error case unit tests
bvtujo d687d58
Update ecs-params reference to only comment on finite/conditional params
bvtujo 7cc516e
Merge branch 'master' into efs-support
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add tests for the error cases as well? (no system id, encryption required but missing)