Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specified var/run/docker.sock directly to mount it #1143

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from

Conversation

hkawa608
Copy link

@hkawa608 hkawa608 commented Feb 22, 2022

Specified the var/run/docker.sock file clearly instead of the var/run folder for the host mount configurations.

  • This file is created as a symbolic link with /Users/${username}/.docker/run/docker.sock in Mac environment.
  • With the folder mount configurations, /var/run/docker.sock is also created in a container as a symbolic link with the same path. Users or programs can not access the host's file path from inside a container, they cannot also access the socket file.
  • On the other hand, with the file mount configurations, /var/run/docker.sock is created as a genuine file, not a symbolic link. So they can access the socket file.

Fixed #1144


Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • [N/A] Unit tests passed
  • [N/A] Integration tests passed
  • [N/A] Unit tests added for new functionality
  • [N/A] Listed manual checks and their outputs in the comments (example)
  • [N/A] Link to issue or PR for the integration tests:

Documentation

  • [N/A] Contacted our doc writer
  • [N/A] Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECS_CONTAINER_METADATA_URI is not accessible in macOS
1 participant