From 1f73fe1570b1a74fcd7db51cd4a742227811162f Mon Sep 17 00:00:00 2001 From: Adam <90734270+adam-mateen@users.noreply.github.com> Date: Fri, 4 Nov 2022 13:43:13 -0500 Subject: [PATCH 1/2] Disable nvidia gpu metrics on windows (it has never been released). --- .../sampleConfig/complete_windows_config.conf | 8 -------- .../sampleConfig/complete_windows_config.json | 9 --------- .../translate/metrics/metrics_collect/gpu/nvidiaSmi.go | 2 +- 3 files changed, 1 insertion(+), 18 deletions(-) diff --git a/translator/totomlconfig/sampleConfig/complete_windows_config.conf b/translator/totomlconfig/sampleConfig/complete_windows_config.conf index 90861d7dbb..75f56f4f62 100755 --- a/translator/totomlconfig/sampleConfig/complete_windows_config.conf +++ b/translator/totomlconfig/sampleConfig/complete_windows_config.conf @@ -16,14 +16,6 @@ [inputs] - [[inputs.nvidia_smi]] - bin_path = "C:\\Program Files\\NVIDIA Corporation\\NVSMI\\nvidia-smi.exe" - fieldpass = ["utilization_gpu", "utilization_memory", "power_draw", "temperature_gpu"] - interval = "60s" - tagexclude = ["compute_mode", "pstate", "uuid"] - [inputs.nvidia_smi.tags] - metricPath = "metrics" - [[inputs.logfile]] destination = "cloudwatchlogs" file_state_folder = "c:\\ProgramData\\Amazon\\AmazonCloudWatchAgent\\Logs\\state" diff --git a/translator/totomlconfig/sampleConfig/complete_windows_config.json b/translator/totomlconfig/sampleConfig/complete_windows_config.json index 20d1a42106..5be584626a 100755 --- a/translator/totomlconfig/sampleConfig/complete_windows_config.json +++ b/translator/totomlconfig/sampleConfig/complete_windows_config.json @@ -12,15 +12,6 @@ }, "metrics": { "metrics_collected": { - "nvidia_gpu" : { - "measurement": [ - "utilization_gpu", - "utilization_memory", - "power_draw", - "temperature_gpu" - ], - "metrics_collection_interval": 60 - }, "Processor": { "measurement": [ { diff --git a/translator/translate/metrics/metrics_collect/gpu/nvidiaSmi.go b/translator/translate/metrics/metrics_collect/gpu/nvidiaSmi.go index 3ff3557f5c..9d1844d8ef 100644 --- a/translator/translate/metrics/metrics_collect/gpu/nvidiaSmi.go +++ b/translator/translate/metrics/metrics_collect/gpu/nvidiaSmi.go @@ -69,5 +69,5 @@ func init() { n := new(NvidiaSmi) parent.RegisterLinuxRule(SectionKey_Nvidia_GPU, n) parent.RegisterDarwinRule(SectionKey_Nvidia_GPU, n) - parent.RegisterWindowsRule(SectionKey_Nvidia_GPU, n) + //parent.RegisterWindowsRule(SectionKey_Nvidia_GPU, n) } From 61e88d0b52b46aa6adb8e74d877f61f396a00d1e Mon Sep 17 00:00:00 2001 From: Adam <90734270+adam-mateen@users.noreply.github.com> Date: Fri, 4 Nov 2022 14:40:35 -0500 Subject: [PATCH 2/2] Verify nvidia gpu in JSON is ignored. --- .../sampleConfig/complete_windows_config.json | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/translator/totomlconfig/sampleConfig/complete_windows_config.json b/translator/totomlconfig/sampleConfig/complete_windows_config.json index 5be584626a..24f181ee7a 100755 --- a/translator/totomlconfig/sampleConfig/complete_windows_config.json +++ b/translator/totomlconfig/sampleConfig/complete_windows_config.json @@ -12,6 +12,15 @@ }, "metrics": { "metrics_collected": { + "nvidia_gpu": { + "measurement": [ + "utilization_gpu", + "utilization_memory", + "power_draw", + "temperature_gpu" + ], + "metrics_collection_interval": 60 + }, "Processor": { "measurement": [ {