Update AfrOtaJobDocumentFields_t definition. #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OTA Parser source and include files. Add OTA Parser unit test files. Add OTA Parser CBMC proofs. OTA Parser MISRA fixes.(Directive 4.8 still to be fixed.)
Add misspelled words in unit test files to .cSpellWords.txt Remove steps to clone submodules from ci.yml(now uses fetchContent) Update buildIndexedFileQueryString() to include the terminating null byte when writing to buffer. They are overwritten on the following lines, but there is a build error when running the unitTests via github actions without this.
Update ci.yml so that coverage is able to computed for otaJobParser files. Remove step to copy otaJobParser source files to build directory.
Update ci.yml due to coverage data being computed correctly on an Ubuntu EC2 instance but not the actions runner as it included both jobs.c files. It should only compute coverage on the jobs.c file in the build dir since that has static keywords stripped out for testing.
Update JOBS_HANDLER_* to be OTA_HANDLER_* Update memory_statistics_config to have all source files listed before coreJSON Update verify_manifest to use a sparse checkout.
|
/bot run formatting |
Add https://misra.org.uk to linkAllowList. Link verifier points it out as an invalid link, but that is incorrect so adding it to the allow list.
bradleysmith23
requested review from
manvensh and
kstribrnAmzn
and removed request for
manvensh
manvensh
approved these changes
Nov 9, 2023
ActoryOu
approved these changes
Nov 9, 2023
|
Could you try moving the structure definition into it's own header file. I'm thinking should fix both the MISRA violation and allow this to build without problems. You will simply need to include the definition header for the build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Move definition of AfrOtaJobDocumentFields_t struct back to job_parser.h from job_parser.c
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.