Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MISRA Violation Fixes #86

Merged
merged 5 commits into from
Oct 27, 2023
Merged

MISRA Violation Fixes #86

merged 5 commits into from
Oct 27, 2023

Conversation

bradleysmith23
Copy link
Contributor

*Issue #, if available: N/A

Description of changes:
Fix MISRA violations for API's added to library from https://github.com/FreeRTOS/Labs-Project-ota-example-for-aws-iot-core
Tested with unit tests as well as cbmc proofs.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@bradleysmith23
Copy link
Contributor Author

/bot run formatting

@kstribrnAmzn
Copy link
Member

This wasn't mentioned in your PR description - but you verified the MISRA violations are fixed with our standard tool (Coverity).

Copy link
Member

@kstribrnAmzn kstribrnAmzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! The changes are very clean

Copy link
Member

@AniruddhaKanhere AniruddhaKanhere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

source/jobs.c Show resolved Hide resolved
source/jobs.c Show resolved Hide resolved
@bradleysmith23 bradleysmith23 merged commit 035be83 into aws:main Oct 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants