Add Functionality from core_jobs.c #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add in functionality from core_jobs.c, Update CMakeLists.txt in test directory to fetch coreJSON, and update CMakeLists.txt in unit-test directory to include coreJSON source and header files.
Add tests for NULL and 0 length thingnames for functions that take thingName and thingNameLength as a parameter.
Add check in isThingNameTopicMatch to check for NULL and 0 length thingNames.
Add unit tests for getStartNextPendingJobExecutionMsg() and getUpdateJobExecutionTopic().
Add Unit Tests for getUpdateJobExecutionTopic() and getUpdateJobExecutionMsg().
Add proofs for functions moved over from core_jobs.c. Add output directory within cbmc directory and store output from the most recent run in a file within that directory.
Update to reflect addition of new proofs, and remove artifacts from gitignore thare are no longer generated by running cbmc proofs.
Function names from core_jobs.c now in camelCase. Add --nondet-static flag back to run_proofs.sh Update static variables in jobs.c so cbmc does not havoc them
Update order of parameters input to Jobs_IsJobUpdateStatus in jobs_utest.c as the order of parameters in the definition of the function have changed.
Remove sources/jobs.c from .gitignore since no copy of jobs.c is created here anymore when running cbmc proofs.
Update how submodules are cloned in for memory statistics
Update ci.yml to have a step to clone submodules
|
/bot run formatting |
kstribrnAmzn
previously approved these changes
Oct 18, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Skptak
reviewed
Oct 19, 2023
Move #define's over to jobs.h from jobs.c Add #define's for clientToken, status, and expectedVersion in jobs.h
|
/bot run formatting |
Skptak
approved these changes
Oct 23, 2023
kstribrnAmzn
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Add APIs from core_jobs.c in https://github.com/FreeRTOS/Labs-Project-ota-example-for-aws-iot-core to jobs.c
Add cbmc proofs for functions added from core_jobs.c, reformat cbmc directory
Add unit tests for functions added from core_jobs.c
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.