Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the "float" on recurring runs #141

Closed
cshowersPersonal opened this issue Oct 20, 2023 · 8 comments
Closed

Stop the "float" on recurring runs #141

cshowersPersonal opened this issue Oct 20, 2023 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@cshowersPersonal
Copy link

Describe the bug

  1. The scheduled time for a recurring daily run floats . Meaning over time it changes slightly each run.

  2. Also if you kick off the daily scheduled run, the next scheduled time is changed.

To Reproduce

  1. Create a daily recurring test.
    Let it run for a few days.
    Watch the time change over time.

  2. Create a daily recurring test
    Run it manually
    Observe the next scheduled time has changed.

Expected behavior
The saved scheduled time should remain. I cannot find any value in how it operates today.

The original scheduled time in the screenshot was 6AM . This is a minor example, I typically adjust it every time I change the script. I've seen it deviate as much as 7 minutes in the past.
image (4)

@cshowersPersonal cshowersPersonal added the bug Something isn't working label Oct 20, 2023
@kamyarz-aws
Copy link
Member

Has it ever been more than 15 minutes?

@cshowersPersonal
Copy link
Author

For #1 not that I've noticed. Like I said I update tests regularly and when I do I fix the start time.

For #2 it's really more of an annoying problem. If you have a nightly run that you want to run outside of the scheduled time, the new scheduled time gets updated to the time you're running off-schedule. Which then requires you to edit the test and fix the time.

Bottom line it doesn't make sense that scheduled time changes to last executed time after the test is saved.

@cshowersPersonal
Copy link
Author

Should also mention that we run automated tests and performance tests through the night after our US personnel stop working but before our poland personnel start working. It's only about a 5 hour window and our timings matter because they can step on each other and skew results.

@kamyarz-aws
Copy link
Member

For the first Issue, Can you confirm if step function was triggered on time?

For the second one, this doesnt strike me as a bug as you just mentioned. We can create a feature request to add like a exception times so your original time wont change but you can kick a non-scheduled test.

@cshowersPersonal
Copy link
Author

For first question, sorry I do not understand. Can you please explain? For second question: The SCHEDULED start time is being replaced by LAST RUN TIME. Seems like a bug, but if that's a feature then ya it would be really nice if the SCHEDULED time stays the SCHEDULED time unless the test is edited and the scheduled time is changed.

@kamyarz-aws
Copy link
Member

kamyarz-aws commented Oct 30, 2023

For the second one, That is the expected behaviour. It is designed to set the time automatically only if you start a test now and set the test to rerun daily/weekly on the same time you started the test. Now if you set a time, but start at some other time, the second time takes precedence. That is why I meant when I say it is not a bug. Now we can work out a feature so through GUI maybe you select a checkbox to not override the time, or something like that. For the first one I am looking into it and How it can be enhanced. Some time change is relatively okay because every day we create a new a rule, and that rule have some time shifts. I cant generate a time shift more than 30 seconds on my end. But as I said I try to make it more consistant.

@kamyarz-aws
Copy link
Member

@cshowersPersonal This will be addressed in our next release

@kamyarz-aws
Copy link
Member

kamyarz-aws commented Nov 16, 2023

@cshowersPersonal The latest release is addressing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants