Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Solo.io Istio to revisions #255

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

PetrMc
Copy link
Contributor

@PetrMc PetrMc commented Apr 24, 2024

Issue #,#252

Description of changes:

This PR:

  • Transfers the Solo Istio Distro to the solo-istio-system namespace.
  • Introduces revision support to enable multiple Istio Control Planes to coexist within the same cluster.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Petr McAllister added 4 commits April 23, 2024 16:59
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
Signed-off-by: Petr McAllister <[email protected]>
@elamaran11
Copy link
Contributor

Thankyou @PetrMc for a rapid quick PR. We will get this validated soon.

Copy link
Contributor

@mikemcd3912 mikemcd3912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Environments deploy successfully and tester completes quickly without issue or retries necessary. LGTM

VMware (K8s 1.28, Bottlerocket 1.15): Pods deploy and reach a ready state, tester completes successfully
Baremetal (K8s 1.27, Ubuntu 20.04.6 LTS): Pods deploy and reach a ready state, tester completes successfully
Outposts (K8s 1.27, Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully
Snow (K8s 1.28, Ubuntu 20.04.6 LTS): Pods deploy and reach a ready state, tester completes successfully
EKS (K8s 1.28, x86 Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully
EKS (K8s 1.28, x86 Bottlerocket): Pods deploy and reach a ready state, tester completes successfully
EKS (K8s 1.28, ARM Bottlerocket 1.19): Pods deploy and reach a ready state, tester completes successfully
EKS (K8s 1.28, ARM Amazon Linux 2): Pods deploy and reach a ready state, tester completes successfully

@mikemcd3912 mikemcd3912 merged commit fb15679 into aws-samples:main Apr 26, 2024
1 check passed
@mikemcd3912
Copy link
Contributor

Hi @PetrMc , Apologies for the change here but we needed to revert the PR based on a conflict that we suspect it was causing with the other Istio add-on that we are attempting to run/test alongside Solo. We believe that the use of discoverySelector to isolate solo would remedy the issue. If you could please resubmit the PR with discoverySelector implemented to focus on just the Solo solution that would be appreciated. Thanks, and let me know if you have any questions!

PetrMc pushed a commit to PetrMc/eks-anywhere-addons that referenced this pull request Apr 29, 2024
Signed-off-by: Petr McAllister <[email protected]>
@PetrMc
Copy link
Contributor Author

PetrMc commented Apr 29, 2024

@mikemcd3912 / @elamaran11 - please review #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants