From 6cf9ae1c0085a22c50bc83c73de9cac0c9883f84 Mon Sep 17 00:00:00 2001 From: Reid Vandewiele Date: Wed, 11 Dec 2024 15:52:24 -0800 Subject: [PATCH] Fixup examples in README.md * Conformitron uses AWS Secret Store, and most of the README refers to Secret Store, but the local testing ClusterSecretStores example in the README used Parameter Store instead. This could cause confusion for people not familiar with setting up External Secrets. Fix is to specify SecretStore in the example. * The Flux Kustomization directions for local testing used the same kustomization name for the addon definition and also for its test. This is likely to cause Flux to replace the existing kustomization with the test path, deleting the addon resources themselves. Fix is to use a different name for the testing kustomization. --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 1d722358..c324c915 100644 --- a/README.md +++ b/README.md @@ -138,7 +138,7 @@ metadata: spec: provider: aws: # set secretStore provider to AWS. - service: ParameterStore # Configure service to be Parameter Store + service: SecretsManager # Configure service to be Secrets Manager region: us-west-2 # Region where the secret is. auth: secretRef: @@ -209,9 +209,9 @@ kubectl get services -n $NAMESPACE 🚀 Add Kustomization for testing your test job : ```bash -flux create kustomization addons-snow-partner \ +flux create kustomization addons-snow-partner-testers \ --source=addons \ - --path="./eks-anywhere-snow/testers/Partner" \ + --path="./eks-anywhere-snow/Testers/Partner" \ --prune=true \ --interval=5m ```