Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated code in example #15

Closed
jamie-wearsafe opened this issue Sep 9, 2021 · 3 comments
Closed

Depreciated code in example #15

jamie-wearsafe opened this issue Sep 9, 2021 · 3 comments

Comments

@jamie-wearsafe
Copy link

Remove this use of "setTraceEntity"; it is deprecated.sonarlint(java:S1874)
The method setTraceEntity(Entity) from the type AWSXRayRecorder is deprecatedJava(67108967)
void com.amazonaws.xray.AWSXRayRecorder.setTraceEntity(Entity entity)
Deprecated Use Entity.run(Runnable) or methods in SegmentContextExecutors instead of directly setting the trace entity so it can be restored correctly.

Sets the trace entity value using the implementation provided by the SegmentContext resolved from the segmentContextResolverChain.

Parameters:

entity the trace entity to set

Entity segment = recorder.getTraceEntity();

@srprash
Copy link

srprash commented Apr 19, 2022

The deprecated API setTraceEntity is being used in the MoveFactory.java on the xray-worker branch.

@mwunderl
Copy link
Contributor

Fixed in 6be0d587

@mwunderl
Copy link
Contributor

mwunderl commented May 2, 2022

released in xray-v2

@mwunderl mwunderl closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants