-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with karpenter-provider-aws
1.0.6
#189
Comments
@caleblloyd can you let us know if #190 solved this issue? |
I don't think so, the issue is that API Versions have changed from |
Hey guys, I successfully installed Karpenter with these changes. I believe we are talking about the same issue.
In addition, I downloaded the v1.0.7 source code locally and modified the namespace setting. This was necessary due to a bug where the Karpenter service account is created in the
|
Hi @ClayLu that's great to hear as I am working on the same issue as I wish to upgrade it too. Just to clarify, You downloaded and modified the source code of this library, or Karpenter itself? Also, what about IAM settings, as there are also subtle differences between one hardcoded in library vs CF file for 1.0.0? And do we have a way to override namespace for ServiceAccount using this library? If so could you point to exact changes in library code? |
@knuurr I only download the source code and modify it. I suggest you try it first. Thx. |
How did you manage to build it locally? I get lots of errors for node_modules/@types/node/https.d.ts:306:25 - error TS1109: Expression expected.
306 requestListener?: http.RequestListener<Request, Response>,
~
node_modules/@types/node/https.d.ts:306:66 - error TS1109: Expression expected.
306 requestListener?: http.RequestListener<Request, Response>,
~
node_modules/@types/node/https.d.ts:307:5 - error TS1109: Expression expected.
307 ): Server<Request, Response>;
~
node_modules/@types/node/https.d.ts:307:6 - error TS1128: Declaration or statement expected.
307 ): Server<Request, Response>;
~
node_modules/@types/node/https.d.ts:307:33 - error TS1005: '(' expected.
307 ): Server<Request, Response>;
👾 Task "build » compile" failed when executing "jsii --silence-warnings=reserved-word" (cwd: /Users/qbus/Documents/GitHub/cdk-eks-karpenter) node --version
v18.20.5 |
|
Ok thanks @ClayLu . Looks like it worked in my case too. |
I am installing using the same code as integ.karpenter.ts with the following changes:
The node pool is failing to install with the following error:
Might have to do with the resource API groups changing from
karpenter.k8s.aws/v1beta1
tokarpenter.k8s.aws/v1
?The text was updated successfully, but these errors were encountered: