Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shc_cli not downloading all controls #1

Open
jwayne1000 opened this issue Nov 13, 2023 · 1 comment
Open

shc_cli not downloading all controls #1

jwayne1000 opened this issue Nov 13, 2023 · 1 comment

Comments

@jwayne1000
Copy link

When running the following command, it does not download the full list of controls for my enabled standards:
shc_cli -d

In my case, I have two standards enabled in Security Hub:

  • AWS Foundational Security Best Practices v1.0.0
  • CIS AWS Foundations Benchmark v1.2.0

I suspect pagination is not configured for the describe_standards_controls boto3 call.
@jwayne1000
Copy link
Author

jwayne1000 commented Nov 13, 2023 •
edited
Loading

Added pagination which successfully fixed it for me. I'm able to download the full list of controls for each standard now. Created pull request: #2

@jwayne1000 jwayne1000 mentioned this issue Nov 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jwayne1000