Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One of the Python examples breaks the CI build. #168

Closed
pimlock opened this issue Nov 22, 2019 · 1 comment
Closed

One of the Python examples breaks the CI build. #168

pimlock opened this issue Nov 22, 2019 · 1 comment
Assignees
Labels
bug This issue is a bug. in-progress Issue is being actively worked on. language/python Related to Python examples

Comments

@pimlock
Copy link
Contributor

pimlock commented Nov 22, 2019

🐛 Bug Report

What is the problem?

The CI build for this package is failing currently. There is a problem with building one of the Python examples with this exception:

TypeError: __init__() got an unexpected keyword argument 'subnetType'

Verbose Log

==============================
building project: /home/travis/build/aws-samples/aws-cdk-examples/scripts/../python/ecs/cluster/requirements.txt
==============================

Traceback (most recent call last):
  File "app.py", line 40, in <module>
    ECSCluster(app, "MyFirstEcsCluster")
  File "/tmp/.venv/lib/python3.6/site-packages/jsii/_runtime.py", line 66, in __call__
    inst = super().__call__(*args, **kwargs)
  File "app.py", line 27, in __init__
    vpc_subnets={'subnetType': ec2.SubnetType.PUBLIC}
  File "/tmp/.venv/lib/python3.6/site-packages/jsii/_runtime.py", line 66, in __call__
    inst = super().__call__(*args, **kwargs)
  ...
  File "/tmp/.venv/lib/python3.6/site-packages/aws_cdk/aws_autoscaling/__init__.py", line 4152, in __init__
    if isinstance(vpc_subnets, dict): vpc_subnets = aws_cdk.aws_ec2.SubnetSelection(**vpc_subnets)
TypeError: __init__() got an unexpected keyword argument 'subnetType'

Full log: https://gist.github.com/pimlock/745a7fb8665dca2e6b10aabadb225786

@skinny85
Copy link
Contributor

Fixed by #170 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. in-progress Issue is being actively worked on. language/python Related to Python examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants