fix(actions): reintroduce token to checkout repo in release workflow #848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently the
on-release
workflow is failing due to the following error:remote: error: GH006: Protected branch update failed for refs/heads/main. remote: error: At least 2 approving reviews are required by reviewers with write access.
After a bit of research it appears that this is happening because the workflow is being executed with an identity that doesn't have enough rights to merge onto
main
, which is a protected branch.As a part of #805 I removed the token as I didn't know the impact it would have. At the same time we haven't noticed since because we haven't made any release in the past few weeks.
This pr reintroduces the token into the workflow, as well as adding a comment that documents why it's there.
Resources:
How to verify this change
AFAIK the only reasonably straightforward way to verify this PR is to merge it & try to execute the modified workflow.
Related issues, RFCs
#805
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.