fix(logger): enable sequential invocation in e2e test #658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR addresses the issue of the AWS Lambda function invocation mode in the E2E tests for the Logger package.
Previously, multiple function invocations have always been performed in parallel. However, this made all the cold start checks impossible, because parallel invocations cause multiple cold starts.
The
invokeFunction
helper function now has an additional optional parameterinvocationMode
with allowed optionsPARALLEL
orSEQUENTIAL
. This parameter lets the invokers control how to call the function-under-test.Note: the parameter is of a union type which differs from the original proposal of a
boolean
parameter.The reasoning behind it is simple: it makes the code easier to read.
Compare:
with
How to verify this change
Run the E2E tests for the Logger package. The test
should include cold start equal to TRUE only on the first invocation
has to pass.Follow the steps from the Reproduce section from #590. Only one initialization section has to appear.
Related issues, RFCs
#590
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.