-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(all): make @middy/core
optional
#511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamorosi
added
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
utility:all
labels
Jan 25, 2022
Successful e2e tests execution on this branch. |
2 tasks
saragerion
reviewed
Jan 25, 2022
!!! tip "Using Middy for the first time?" | ||
You can install Middy by running `npm i @middy/core`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the shout out
saragerion
approved these changes
Jan 25, 2022
flochaz
approved these changes
Jan 26, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As detailed in #373
@middy/core
has been bundled in all utilities which means customers who don't use the middleware implementations will have an unnecessary dependency bundled in their Lambda deployment package. This PR aims at correcting that.Changes:
@middy/core
todevDependency
in all utilities that used it (updated also lock file)npm i @middy/core
@middy/core
is adependency
inexamples/cdk
How to verify this change
See checks execution results + e2e result here.
Also ran
npm pack
on one of the utilities and then installed it in a new dummy project (@middy/core
not installed):Related issues, RFCs
#373
PR status
Is this ready for review?: YES
Is it a breaking change?: YES
Checklist
Breaking change checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.