-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tracer): avoid throwing errors in manual instrumentation when running outside of AWS Lambda #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flochaz
previously approved these changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saragerion
reviewed
Jan 10, 2022
saragerion
reviewed
Jan 10, 2022
saragerion
reviewed
Jan 10, 2022
saragerion
reviewed
Jan 10, 2022
saragerion
previously approved these changes
Jan 10, 2022
Left some minor comments but already looks good |
10 tasks
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
Co-authored-by: Sara Gerion <[email protected]>
saragerion
approved these changes
Jan 10, 2022
flochaz
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As reporded by @ijemmy during manual tests manually instrumenting a function with
Tracer
outside of AWS Lambda was throwing an error due to the lack of traces & context.This was a bug since
Tracer
should automatically detect its running outside of Lambda and deactivate itself. The bug affected only manual instrumentation while the Middy middleware and Class decorator were unaffected.Changes:
setContextMissingStrategy()
method from the Node.js x-ray-sdk to disable throwing errors when tracing is disabled.Tracer.setSegment()
&Tracer.getSegment()
to respect value ofTracer. tracingEnabled
Tracer.getSegment()
returns a dummy segment when tracing is disabledTracer.isTracingEnabled()
over accessing attribute directly throughout classHow to verify this change
Check that all checks are successful, OR:
cd packages/tracing && npm run package
Related issues, RFCs
N/A
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.