Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): disable metrics with POWERTOOLS_METRICS_DISABLED #3351

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat(metrics): disable metrics with POWERTOOLS_METRICS_DISABLED #3351

merged 4 commits into from
Nov 25, 2024
+158 −2

Conversation

zirkelc
Copy link
Contributor

@zirkelc zirkelc commented Nov 24, 2024

Summary

Changes

Please provide a summary of what's being changed

Add a new environment variable POWERTOOLS_METRICS_DISABLED to disable emitting metrics.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: #3329

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@zirkelc zirkelc requested review from a team as code owners November 24, 2024 13:35
@boring-cyborg boring-cyborg bot added metrics This item relates to the Metrics Utility tests PRs that add or change tests labels Nov 24, 2024
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Nov 24, 2024
@dreamorosi dreamorosi linked an issue Nov 24, 2024 that may be closed by this pull request
Feature request: ability to silence / skip publishing metrics via env variable #3329
Closed
2 tasks
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Nov 24, 2024
@boring-cyborg boring-cyborg bot added the commons This item relates to the Commons Utility label Nov 25, 2024
@pull-request-size pull-request-size bot added size/L PRs between 100-499 LOC and removed size/M PR between 30-99 LOC labels Nov 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
14.7% Duplication on New Code

See analysis details on SonarQube Cloud

@dreamorosi dreamorosi self-requested a review November 25, 2024 09:48
dreamorosi
dreamorosi approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the high quality PR @zirkelc - really appreciate it!

And congrats for the first PR merged into this project!

@dreamorosi dreamorosi merged commit 7e8578e into aws-powertools:main Nov 25, 2024
37 checks passed
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented Nov 25, 2024

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

@zirkelc
Copy link
Contributor Author

zirkelc commented Nov 25, 2024

Thank you @dreamorosi!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamorosi dreamorosi dreamorosi approved these changes

Assignees

@zirkelc zirkelc

Labels
commons This item relates to the Commons Utility feature PRs that introduce new features or minor changes metrics This item relates to the Metrics Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature request: ability to silence / skip publishing metrics via env variable
2 participants
@zirkelc @dreamorosi