Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): ability to set custom timestamp with setTimestamp for metrics #3310

Merged

Conversation

arnabrahman
Copy link
Contributor

Summary

By default, the current timestamp is set while creating metrics. This PR provides an opportunity to provide custom timestamp with metrics

Changes

  • Followed the Python implementation of the same feature for feature parity
  • Create setTimestamp function to set the timestamp
  • Validate the timestamp, if not a valid timestamp then log a warning
  • Set the timestamp, if not a valid value set this to Zero for Cloudwatch to skip
  • Write unit tests for the function, had to slightly change the date mock to test the new feature
  • Add a section for the feature inside the doc

Issue number: #3153


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation metrics This item relates to the Metrics Utility tests PRs that add or change tests labels Nov 12, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Nov 12, 2024
@arnabrahman arnabrahman marked this pull request as ready for review November 12, 2024 04:20
@arnabrahman arnabrahman requested a review from a team November 12, 2024 04:20
@arnabrahman arnabrahman requested a review from a team as a code owner November 12, 2024 04:20
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @arnabrahman, looking good.

I've left a couple minor comments and a question

@arnabrahman arnabrahman marked this pull request as draft November 12, 2024 16:27
@dreamorosi dreamorosi self-requested a review November 12, 2024 16:52
@arnabrahman arnabrahman marked this pull request as ready for review November 12, 2024 16:53
@dreamorosi dreamorosi merged commit 0fb94c3 into aws-powertools:main Nov 13, 2024
27 checks passed
@arnabrahman arnabrahman deleted the 3153-metrics-custom-timestamp branch November 13, 2024 10:34
@dreamorosi
Copy link
Contributor

Hey @arnabrahman, just dropping this issue here (#3302) in case you're looking for something else to work on.

It's in the same area as this one and should be fairly simple. If not interested, feel free to chose another (if any)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation metrics This item relates to the Metrics Utility size/L PRs between 100-499 LOC tests PRs that add or change tests
Projects
None yet
3 participants