-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): ability to set custom timestamp with setTimestamp
for metrics
#3310
feat(metrics): ability to set custom timestamp with setTimestamp
for metrics
#3310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @arnabrahman, looking good.
I've left a couple minor comments and a question
…n/aws-lambda-powertools-typescript into 3153-metrics-custom-timestamp
|
Hey @arnabrahman, just dropping this issue here (#3302) in case you're looking for something else to work on. It's in the same area as this one and should be fairly simple. If not interested, feel free to chose another (if any) |
Summary
By default, the current timestamp is set while creating metrics. This PR provides an opportunity to provide custom timestamp with metrics
Changes
setTimestamp
function to set the timestampZero
for Cloudwatch to skipIssue number: #3153
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.