Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: add forcePublish flag to lerna config #3229

Closed
1 of 2 tasks
am29d opened this issue Oct 22, 2024 · 2 comments · Fixed by #3238
Closed
1 of 2 tasks

Maintenance: add forcePublish flag to lerna config #3229

am29d opened this issue Oct 22, 2024 · 2 comments · Fixed by #3238
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@am29d
Copy link
Contributor

am29d commented Oct 22, 2024

Summary

In the last release the versioning workflow did not bump the parser package, which is not what we expected. After going through all the commits between the releases it turned out that for all the releases before that, we had commits that were picked up by lerna and versioning worked as expected. These are usually dependabot or repo wide changes, i.e. new customer reference, that would affect all packages.

In the last two weeks there was not a single commit to the parser package, and thus lerna versioning did not bump it.

To avoid that in the future, we should add forcePublish flag to the lerna.json configuration.

Why is this needed?

So lerna bumps all package version regardless of commit history.

Which area does this relate to?

Automation

Solution

No response

Acknowledgment

Future readers

Please react with 👍 and your use case to help us understand customer demand.

@am29d am29d added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) triage This item has not been triaged by a maintainer, please wait labels Oct 22, 2024
@am29d am29d added automation This item relates to automation confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Oct 22, 2024
@am29d am29d self-assigned this Oct 23, 2024
@am29d am29d moved this from Triage to Working on it in Powertools for AWS Lambda (TypeScript) Oct 23, 2024
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (TypeScript) Oct 23, 2024
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Working on it in Powertools for AWS Lambda (TypeScript) Oct 23, 2024
@dreamorosi dreamorosi moved this from Working on it to Closed in Powertools for AWS Lambda (TypeScript) Oct 23, 2024
@dreamorosi dreamorosi moved this from Closed to Shipped in Powertools for AWS Lambda (TypeScript) Oct 23, 2024
@github-actions github-actions bot added pending-release This item has been merged and will be released soon and removed confirmed The scope is clear, ready for implementation labels Oct 23, 2024
Copy link
Contributor

This is now released under v2.10.0 version!

@github-actions github-actions bot added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
1 participant