feat(logger): include enumerable properties in formatted errors #3195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR improves the logic used to format errors for Logger to start including all enumerable properties of the error including both own and inherited.
This change was done in response to customer demand and considering it's additive, we don't consider it as a breaking change.
Consider the following error:
Before this change, calling
logger.error('An error occurred', new SuperCustomError('foo', 303));
generated this log:This missed properties that customers might have wanted to see, making the troubleshooting harder than needed.
After the change, the log will instead look like this:
Issue number: closes #2170
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.