-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(batch): add option to not throw FullBatchFailureError
when the entire batch fails
#2711
feat(batch): add option to not throw FullBatchFailureError
when the entire batch fails
#2711
Conversation
…hFailureError` error
…r for full batch failure
…FullBatchFailure` option
Note to remember: @dreamorosi please let's talk before/after merging this PR to see if it makes sense to add the same in Python and @aws-powertools/lambda-dotnet-core cc @hjgraca |
Hi @leandrodamascena, we talked about if a few weeks ago when we did the v3 planning, the consensus was yes, since it impacts the scaling of the poller in some cases. We can talk about it again also. |
Hi @arnabrahman - thank you for the PR! I'll wait until I can talk with @leandrodamascena tomorrow to start reviewing the PR. Thank you for your patience! |
Hi @arnabrahman - thank you for the patience. I'll make a couple of commits to the branch to explain the feature in the documentation before we can merge it. |
And to follow up on this: we went through the feature and we are aligned on the fact that we should move forward. We will also add the same flag on the other versions as time allows it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Amazing work @arnabrahman and @dreamorosi!
I'm adding this new feature in Python.
Summary
Currently, when using the Batch Processor utility, if all the records in a batch are marked as failed, the utility throws a
FullBatchFailureError
. However, there can be scenarios where we do not want to throw an error for this condition.This PR adds a
throwOnFullBatchFailure
option, giving users the ability to bypass theFullBatchFailureError
when the entire batch fails.Changes
throwOnFullBatchFailure
option that can be passed as an option insideprocessPartialResponse
orprocessPartialResponseSync
functionsthrowOnFullBatchFailure
is false, we will not throwFullBatchFailureError
exceptionthrowOnFullBatchFailure
is not provided or istrue
, we will keep the current implementation of throwingFullBatchFailureError
exceptionand
processPartialResponseSync` functionIssue number: #2122
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.