Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): lambda function url cognitoIdentity and principalOrgId nullable #2430

Merged
merged 5 commits into from
Apr 24, 2024

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Apr 24, 2024

Description of your changes

This PR closes #2427 . I have used optional in most of the places where we don't expect to have a value, but this did not cover the null value case.

Related issues, RFCs

Issue number: closes #2427

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@am29d am29d requested review from a team as code owners April 24, 2024 10:02
@boring-cyborg boring-cyborg bot added parser This item relates to the Parser Utility tests PRs that add or change tests labels Apr 24, 2024
@pull-request-size pull-request-size bot added the size/S PR between 10-29 LOC label Apr 24, 2024
@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further bug Something isn't working labels Apr 24, 2024
@am29d am29d self-assigned this Apr 24, 2024
@am29d am29d requested a review from dreamorosi April 24, 2024 10:26
@aws-powertools aws-powertools deleted a comment from github-actions bot Apr 24, 2024
@am29d am29d removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Apr 24, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dreamorosi dreamorosi merged commit 3c3e393 into main Apr 24, 2024
10 checks passed
@dreamorosi dreamorosi deleted the fix/2427-lambda-function-url-nullable branch April 24, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parser This item relates to the Parser Utility size/S PR between 10-29 LOC tests PRs that add or change tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: LambdaFunctionUrlSchema fails with CloudFront Origin Access Control (OAC)
2 participants