fix(jmespath): refactor custom function introspection to work with minification #2384
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes a bug that caused JMESPath custom functions to fail to be detected and throw a runtime error when running on minified functions.
The previous logic relied on the name of the class (via
prototype.constructor.name
) which caused it to fail when the code is minified since entities are aliased to use shorter names.The new logic introduced in this PR uses an identity check (
value instanceof Class
) which minification-proof since even when aliased both classes will still maintain their inheritance.Related issues, RFCs
Issue number: #2383
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.