fix(idempotency): record validation not using hash #1502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As reported in the linked issue, the persistence layer for the Idempotency utility was not using the payload hash when payload validation was enabled. This was caused by two issues:
validation
, on subsequent requests the value was discarded at runtime and not used when instantiating theIdempotencyRecord
Both issues have been fixed in this PR. The PR also contains an unrelated change that aligns the name of the in progress expiry attribute with the reference implementation (
in_progress_expiration
).Related issues, RFCs
Issue number: #1499
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.