Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parameters): add clearCaches function #1382

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

As described in the linked issue, there's a need for a clearCaches helper function in the Parameters utility so that users can easily control cache eviction when testing code that uses the utility.

This PR introduces the function as part of the BaseProvider and adds unit tests for it. Once merged this PR will close #1381.

How to verify this change

See new unit tests in the PR checks.

Related issues, RFCs

Issue number: #1381

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@dreamorosi dreamorosi self-assigned this Mar 25, 2023
@dreamorosi dreamorosi linked an issue Mar 25, 2023 that may be closed by this pull request
2 tasks
@pull-request-size pull-request-size bot added the size/M PR between 30-99 LOC label Mar 25, 2023
@github-actions github-actions bot added the feature PRs that introduce new features or minor changes label Mar 25, 2023
@dreamorosi dreamorosi merged commit ec49023 into main Mar 25, 2023
@dreamorosi dreamorosi deleted the 1381-add-clearcaches-method-for-testing branch March 25, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature PRs that introduce new features or minor changes size/M PR between 30-99 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: add clearCaches method for testing
1 participant