Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: implement IdempotencyHandler #1303

Closed
1 of 2 tasks
saragerion opened this issue Feb 17, 2023 · 1 comment · Fixed by #1416
Closed
1 of 2 tasks

Feature request: implement IdempotencyHandler #1303

saragerion opened this issue Feb 17, 2023 · 1 comment · Fixed by #1416
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility idempotency This item relates to the Idempotency Utility

Comments

@saragerion
Copy link
Contributor

saragerion commented Feb 17, 2023

Use case

All the usages of the Idempotency utility described in #447 share most of their internal logic. This is because in all cases, there are some actions to be taken before and after the function being made idempotent.

For this reason the logic that handles idempotency can be extracted in its own class and reused across all access patterns. This class should be called IdempotencyHandler.

Note that there's already an initial basic implementation of the class under packages/idempotency/src. As a part of this issue, the resolver should revisit this function and align the implementation with the version seen in Powertools for Python.

Solution/User Experience

Users should not use this class directly. The class will be used under the hood by the decorator, Middy middleware, and wrapper function.

Alternative solutions

No response

Acknowledgment

@saragerion saragerion added triage This item has not been triaged by a maintainer, please wait feature-request This item refers to a feature request for an existing or new utility labels Feb 17, 2023
@saragerion saragerion added this to the Idempotency - Beta release milestone Feb 17, 2023
@saragerion saragerion added the idempotency This item relates to the Idempotency Utility label Feb 17, 2023
@dreamorosi dreamorosi changed the title Feature request (idempotency): Exceptions management Feature request: Exceptions management Feb 17, 2023
@dreamorosi dreamorosi added discussing The issue needs to be discussed, elaborated, or refined and removed triage This item has not been triaged by a maintainer, please wait labels Feb 17, 2023
@dreamorosi dreamorosi changed the title Feature request: Exceptions management Feature request: implement IdempotencyHandler Mar 20, 2023
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation and removed discussing The issue needs to be discussed, elaborated, or refined labels Mar 20, 2023
@dreamorosi dreamorosi changed the title Feature request: implement IdempotencyHandler Feature request: implement IdempotencyHandler Mar 20, 2023
@am29d am29d self-assigned this Mar 27, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in AWS Lambda Powertools for TypeScript Apr 25, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Apr 25, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Apr 25, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility idempotency This item relates to the Idempotency Utility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants