Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: make docs/snippets part of the npm workspace #1250

Closed
1 of 2 tasks
dreamorosi opened this issue Jan 16, 2023 · 1 comment · Fixed by #1251
Closed
1 of 2 tasks

Maintenance: make docs/snippets part of the npm workspace #1250

dreamorosi opened this issue Jan 16, 2023 · 1 comment · Fixed by #1251
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)

Comments

@dreamorosi
Copy link
Contributor

Summary

As discussed as part of issue #729, in order to follow best practices and be able to lint the code snippets introduced in the docs/ folder, we should make the docs/snippets/ folder part of the npm workspace.

Why is this needed?

So that we can automate checking the correctness of the code snippets that are part of the docs, leading to a better DX.

Which area does this relate to?

Governance

Solution

No response

Acknowledgment

@dreamorosi dreamorosi added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) confirmed The scope is clear, ready for implementation labels Jan 16, 2023
@dreamorosi dreamorosi self-assigned this Jan 16, 2023
@dreamorosi dreamorosi added the automation This item relates to automation label Jan 16, 2023
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in AWS Lambda Powertools for TypeScript Jan 16, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Jan 16, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Feb 21, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.)
Projects
Development

Successfully merging a pull request may close this issue.

1 participant