Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: implement SSMProvider #1176

Closed
3 of 4 tasks
dreamorosi opened this issue Nov 17, 2022 · 8 comments · Fixed by #1187
Closed
3 of 4 tasks

Feature request: implement SSMProvider #1176

dreamorosi opened this issue Nov 17, 2022 · 8 comments · Fixed by #1187
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility parameters This item relates to the Parameters Utility

Comments

@dreamorosi
Copy link
Contributor

dreamorosi commented Nov 17, 2022

Summary

The Parameters utility should allow customers to retrieve one or more parameters stored in AWS Systems Manager.

This work includes the following tasks:

  • Write provider + types
  • Unit tests (100% coverage)

Why is this needed?

1/ So that customers are able to retrieve parameters from SSM, 2/ to reach feature parity with Powertools for Python.

Which area does this relate to?

Parameters

Solution

No response

Acknowledgment

@dreamorosi dreamorosi added feature-request This item refers to a feature request for an existing or new utility confirmed The scope is clear, ready for implementation parameters This item relates to the Parameters Utility labels Nov 17, 2022
@dreamorosi dreamorosi added this to the Parameters - Beta release milestone Nov 17, 2022
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Nov 21, 2022
@dreamorosi dreamorosi self-assigned this Nov 21, 2022
@buggy
Copy link

buggy commented Nov 29, 2022

If it's not actively being worked on by someone else then I'd love to have a go at implementing.

@flochaz
Copy link
Contributor

flochaz commented Nov 29, 2022

Hi @buggy, thanks for your interest. I think @dreamorosi is already working on it. Let's wait for his answer before investing time in it (he is at re:invent at the moment so his answer might come late).

@dreamorosi
Copy link
Contributor Author

Hi @buggy thanks for offering to contribute to our project.

As Florian mentioned the PR for SSMProvider should be up for review early next week (Monday/Tuesday). Perhaps you could be one of the reviewers for the PR and then take up the implementation of any of the other providers for Parameters. This way we can have a first provider merged and use it as an example for the others.

What do you think?

@buggy
Copy link

buggy commented Dec 3, 2022

@dreamorosi I'm happy to help.

@shdq
Copy link
Contributor

shdq commented Dec 3, 2022

Hey there! I would like to join too and then implement AppConfigProvider #1177 with a bit of @dreamorosi's guidance 😉

@dreamorosi
Copy link
Contributor Author

Hi everyone, sorry for going dark in the past days. After re:Invent I got sick (now I'm fine!) and wasn't able to finish the PR. I'm planning on having it up by mid this week, so that you can start reviewing it.

@dreamorosi dreamorosi linked a pull request Dec 13, 2022 that will close this issue
13 tasks
@dreamorosi
Copy link
Contributor Author

Hi folks, I have opened a draft PR (#1187) with the main features for SSMProvider.

The PR is still a draft because there are some additional features from Python that I still need to implement, however the base SSMProvider class as well as the getParameter and getParameters functions are there.

This should be enough to get started with the other providers given that they only implement these or a subset of these patterns.

If you're still interested in contributing I would suggest starting with a proposal under the respective issue of each provider.

@dreamorosi dreamorosi moved this from Working on it to Pending review in AWS Lambda Powertools for TypeScript Dec 28, 2022
@github-project-automation github-project-automation bot moved this from Pending review to Coming soon in AWS Lambda Powertools for TypeScript Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot added the pending-release This item has been merged and will be released soon label Jan 5, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed pending-release This item has been merged and will be released soon confirmed The scope is clear, ready for implementation labels Jan 13, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility parameters This item relates to the Parameters Utility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants