Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Custom Config - Number of seconds to wait before a record is expired #1158

Closed
1 of 2 tasks
ijemmy opened this issue Nov 11, 2022 · 1 comment · Fixed by #1376
Closed
1 of 2 tasks
Assignees
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility idempotency This item relates to the Idempotency Utility

Comments

@ijemmy
Copy link
Contributor

ijemmy commented Nov 11, 2022

Use case

Description of the feature request

Problem statement
Library users want to specify how long does the idempotency record should last. Once it's expired, the library should behave like there is no such record

Check the design spec for details.

Summary of the feature

  • Add expiresAfterSeconds input
  • Cover edge cases:
    • What if the record expires between PersistenceLayer.saveInProgress() and PersistenceLayer.saveSuccess()?
    • How should PersistenceLayer.saveInProgress() override an expired items?
    • Is there any impact if PersistenceLayer.getRecord() return an expired item? Is there a logic for checking expiration in the library?

Code examples
See the design spec

Story Checklist (for tracking progress)

TBD by an assignee

Definition of done

  • Include unit tests with 100% code coverage (or where it makes sense)

In scope

  • Errors handling
  • Handling scenario of executions in sequence only
  • Unit tests

Out of scope

Related issues, RFCs

#447

Solution/User Experience

See #447

Alternative solutions

N/A

Acknowledgment

@ijemmy ijemmy added triage This item has not been triaged by a maintainer, please wait idempotency This item relates to the Idempotency Utility labels Nov 11, 2022
@dreamorosi dreamorosi added this to the Idempotency - Beta release milestone Nov 11, 2022
@dreamorosi dreamorosi added confirmed The scope is clear, ready for implementation feature-request This item refers to a feature request for an existing or new utility and removed triage This item has not been triaged by a maintainer, please wait labels Nov 13, 2022
@dreamorosi dreamorosi changed the title Feature (idempotency): Can customize time window to expire the record (FR4) Feature request: Can customize time window to expire the record (FR4) Nov 14, 2022
@saragerion saragerion changed the title Feature request: Can customize time window to expire the record (FR4) Feature request(idempotency): custom config - Number of seconds to wait before a record is expired Feb 17, 2023
@saragerion saragerion changed the title Feature request(idempotency): custom config - Number of seconds to wait before a record is expired Feature request(idempotency): Custom Config - Number of seconds to wait before a record is expired Feb 17, 2023
@dreamorosi dreamorosi changed the title Feature request(idempotency): Custom Config - Number of seconds to wait before a record is expired Feature request: Custom Config - Number of seconds to wait before a record is expired Feb 17, 2023
@dreamorosi dreamorosi self-assigned this Mar 20, 2023
@dreamorosi dreamorosi moved this from Backlog to Working on it in AWS Lambda Powertools for TypeScript Mar 20, 2023
@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in AWS Lambda Powertools for TypeScript Mar 30, 2023
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Mar 30, 2023
@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed This item is complete and has been merged/shipped feature-request This item refers to a feature request for an existing or new utility idempotency This item relates to the Idempotency Utility
Projects
None yet
2 participants