fix(tracer): captureMethod detects proper method name when used with external decorators #1109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In #1093 it has been reported that the
tracer.captureMethod
decorator was not properly detecting the name of the decorated class method, causing the name of the segment and the corresponding metadata entry to have an empty name.I.e.
@misterjoshua, who opened the initial issue, also suggested a potential fix which was used in this PR.
This PR also adds an unit test case to demonstrate the fix.
How to verify this change
See new unit test case that was added in this PR.
Related issues, RFCs
Issue number: #1093
PR status
Is this ready for review?: YES
Is it a breaking change?: NO
Checklist
Breaking change checklist
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.