Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: integrate utility with CI/CD unit test processes #1100

Closed
ijemmy opened this issue Sep 29, 2022 · 2 comments · Fixed by #1160
Closed

Maintenance: integrate utility with CI/CD unit test processes #1100

ijemmy opened this issue Sep 29, 2022 · 2 comments · Fixed by #1160
Assignees
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility tests PRs that add or change tests

Comments

@ijemmy
Copy link
Contributor

ijemmy commented Sep 29, 2022

Description of the feature request

Problem statement
Even if the new utility won't be released till much later, whenever code is merged into main the code coverage should stay at 100%.

Summary of the feature
This unit of work tracks the activities and changes needed for the idempotency utility to be part of the unit test workflows that run whenever a PR is created and/or updated.

Additionally, the new utility should also be part of the husky hooks that are ran locally before committing.

Code examples
N/A

Benefits for you and the wider AWS community
N/A

Describe alternatives you've considered
None, tests must be there.

Additional context
N/A

Related issues, RFCs

#447

@ijemmy ijemmy added triage This item has not been triaged by a maintainer, please wait idempotency This item relates to the Idempotency Utility labels Sep 29, 2022
@saragerion saragerion added this to the Idempotency milestone Sep 29, 2022
@ijemmy ijemmy self-assigned this Nov 11, 2022
@dreamorosi dreamorosi moved this from Working on it to Pending review in AWS Lambda Powertools for TypeScript Nov 13, 2022
@dreamorosi dreamorosi linked a pull request Nov 13, 2022 that will close this issue
13 tasks
@dreamorosi
Copy link
Contributor

Hi @ijemmy I'm so sorry, I just noticed that there was this issue opened and I started working on this on Friday.

The reason why I worked on it so soon was that after merging #1110 the "on-merge" Action is failing due to inconsistencies in the package-lock.json file.

I would still appreciate your review on #1160 whenever you're ready next week.

Again, apologies for the confusion. Had I noticed that you already assigned this to you I would not have opened the PR and talked to you first.

@dreamorosi dreamorosi added automation This item relates to automation tests PRs that add or change tests confirmed The scope is clear, ready for implementation and removed triage This item has not been triaged by a maintainer, please wait labels Nov 13, 2022
@dreamorosi dreamorosi self-assigned this Nov 14, 2022
@dreamorosi dreamorosi changed the title Feature (idempotency): integrate utility with CI/CD unit test processes Feature request: integrate utility with CI/CD unit test processes Nov 14, 2022
@dreamorosi dreamorosi changed the title Feature request: integrate utility with CI/CD unit test processes Maintenance: integrate utility with CI/CD unit test processes Nov 14, 2022
Repository owner moved this from Pending review to Coming soon in AWS Lambda Powertools for TypeScript Nov 24, 2022
@github-actions
Copy link
Contributor

⚠️ COMMENT VISIBILITY WARNING ⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@dreamorosi dreamorosi moved this from Coming soon to Shipped in AWS Lambda Powertools for TypeScript Mar 2, 2023
@dreamorosi dreamorosi added completed This item is complete and has been merged/shipped and removed confirmed The scope is clear, ready for implementation labels Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation completed This item is complete and has been merged/shipped idempotency This item relates to the Idempotency Utility tests PRs that add or change tests
Projects
None yet
3 participants