Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Review pipeline to update the aws-actions/configure-aws-credentials action #3025

Closed
2 tasks done
leandrodamascena opened this issue Aug 29, 2023 · 5 comments
Closed
2 tasks done
Assignees
Labels
internal Maintenance changes v3 Features that will be included in Powertools v3.

Comments

@leandrodamascena
Copy link
Contributor

Why is this needed?

The v3 major version of aws-actions/configure-aws-credentials has been released and is breaking our CI.

The role assumed in https://github.com/aws-powertools/powertools-lambda-python/blob/develop/.github/workflows/reusable_deploy_v2_sar.yml#L182 is different from the role that should be outputted by this command https://github.com/aws-powertools/powertools-lambda-python/blob/develop/.github/workflows/reusable_deploy_v2_sar.yml#L103.

Also, accountid is not masked by default and need to add special configuration to avoid problems with special characters (https://github.com/aws-actions/configure-aws-credentials#special-characters-in-aws_secret_access_key).

Which area does this relate to?

Automation

Solution

Investigate these problems before update this dependency.

Acknowledgment

@dreamorosi
Copy link
Contributor

We merged the change and confirmed that the new version works: aws-powertools/powertools-lambda-typescript#1662

Another change in 3.x is that you now have to pass output-credentials for the credentials to be set as output of the step. We are not using that feature since we read from the environment, but you might have to put it since one of your examples reads from the steps.

@leandrodamascena
Copy link
Contributor Author

Hello @dreamorosi! Thank you so much for sharing this. I think our issue is with this output-credentials parameter. We'll investigate further, but this investigation of yours has shortened the path by miles.

🚀

@leandrodamascena leandrodamascena moved this from Working on it to On hold in Powertools for AWS Lambda (Python) Aug 29, 2023
@leandrodamascena leandrodamascena removed the triage Pending triage from maintainers label Sep 1, 2023
@heitorlessa heitorlessa added the triage Pending triage from maintainers label Jun 9, 2024
@heitorlessa heitorlessa moved this from On hold to Triage in Powertools for AWS Lambda (Python) Jun 10, 2024
@heitorlessa
Copy link
Contributor

Adding triage back as I'm not sure where we landed with this. I suspect it's done?

@dreamorosi dreamorosi moved this from Triage to On hold in Powertools for AWS Lambda (Python) Jul 22, 2024
@dreamorosi dreamorosi added v3 Features that will be included in Powertools v3. and removed triage Pending triage from maintainers labels Jul 22, 2024
@dreamorosi dreamorosi moved this from On hold to Working on it in Powertools for AWS Lambda (Python) Jul 22, 2024
@leandrodamascena
Copy link
Contributor Author

This was updated in V3 pipeline! Closing.

@github-project-automation github-project-automation bot moved this from Working on it to Coming soon in Powertools for AWS Lambda (Python) Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes v3 Features that will be included in Powertools v3.
Projects
Status: Coming soon
Development

No branches or pull requests

3 participants