Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Migrate to CDK CLI and off Docker for E2E tests #1500

Closed
1 of 2 tasks
heitorlessa opened this issue Sep 5, 2022 · 2 comments
Closed
1 of 2 tasks

Maintenance: Migrate to CDK CLI and off Docker for E2E tests #1500

heitorlessa opened this issue Sep 5, 2022 · 2 comments
Assignees
Labels
tech-debt Technical Debt tasks

Comments

@heitorlessa
Copy link
Contributor

Summary

This tracks the work necessary to use CDK CLI for synthesizing and deploying E2E stacks in parallel. It also tracks our initial move away from Docker to build Lambda Layer, as it slows down E2E authoring significantly (~1.3m) for every individual run.

Why is this needed?

For v2, @rubenfonseca needed to use the default VPC for Event Handler E2E test. We were caught by surprise that CDK Context Lookup methods only work via CDK CLI, which invalidates our initial implementation.

Which area does this relate to?

Tests

Solution

PR incoming. We've successfully moved to use CDK CLI while keeping our authoring and parallel deployment experience.

Acknowledgment

@heitorlessa heitorlessa added triage Pending triage from maintainers internal Maintenance changes labels Sep 5, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Sep 5, 2022
@heitorlessa heitorlessa self-assigned this Sep 5, 2022
@github-actions github-actions bot added the pending-release Fix or implementation already in dev waiting to be released label Sep 20, 2022
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

This is now released under 1.30.0 version!

@github-actions github-actions bot removed the pending-release Fix or implementation already in dev waiting to be released label Oct 5, 2022
@heitorlessa heitorlessa added tech-debt Technical Debt tasks and removed internal Maintenance changes labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Technical Debt tasks
Projects
None yet
Development

No branches or pull requests

1 participant